Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting Text & Clarify Irrigation Demand Timing and Flow Discrepancies in Tutorial #2001

Closed
christianli24 opened this issue Jan 8, 2025 · 1 comment · Fixed by #2009
Closed
Labels
documentation Improvements or additions to documentation

Comments

@christianli24
Copy link

The irrigation demand in the tutorial currently ends at the end of September instead of August (the text description in the irrigation demand tutorial section should be corrected).

Additionally, the explanation regarding the relationship between time and demand=[0.0, 0.0, 10, 12, 12, 0.0] in the user_demand.Time example is unclear. Could this explanation be made more detailed and explicit?

It would be helpful to elaborate on how time is connected to demand values. For example, my understanding of the intended demand values is as follows:

1 Jan 2022: 0 m³/s
31 Mar 2022: 0 m³/s
1 Apr 2022: 10 m³/s
1 Jul 2022: 12 m³/s
30 Sep 2022: 12 m³/s
1 Oct 2022: 0 m³/s

However, the flow in the "irrigation" edge shows different values when using the interactive plotting tool. The observed flow values appear to indicate discrepancies, such as:

1 Jan 2022: 0 m³/s
31 Mar 2022: 5 m³/s → Suggesting additional water is being drawn from the main edge.
1 Apr 2022: 10 m³/s
1 Jul 2022: 12 m³/s
30 Sep 2022: 6 m³/s → Suggesting that the irrigation demand is not fully met.
1 Oct 2022: 0 m³/s

This issue needs clarification, especially regarding how the irrigation demand values are defined.

Image

@github-project-automation github-project-automation bot moved this to To do in Ribasim Jan 8, 2025
@visr visr added the documentation Improvements or additions to documentation label Jan 9, 2025
@visr
Copy link
Member

visr commented Jan 14, 2025

Thanks, I changes August to September in #2009.

Regarding the demand values and resulting flows. The demand on 2022-03-31 00:00 is 0, and 24h later on 2022-04-01 00:00 it is 10. In between it interpolates linearly. The flow output at 2022-03-31 00:00 gives the average flow over the coming 24 hours, which is 5. This output should be the average such that we can reproduce the water balance properly. This behavior is documented at https://ribasim.org/reference/usage.html#flow---flow.arrow.

If you have suggestions on how to further clarify this please let us know. I'm glad you are questioning the precise values.

Image

@visr visr closed this as completed in 0d5ad06 Jan 17, 2025
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Jan 17, 2025
@github-project-automation github-project-automation bot moved this from To do to ✅ Done in Ribasim Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants