Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace common feature with default #247

Closed
visr opened this issue Feb 4, 2025 · 0 comments · Fixed by #249
Closed

Replace common feature with default #247

visr opened this issue Feb 4, 2025 · 0 comments · Fixed by #249
Assignees
@visr

Comments

@visr
Copy link
Member

visr commented Feb 4, 2025

We currently don't define any default dependencies, only the under the common feature. We may as well use the default feature instead of common. @rbruijnshkv already added ipykernel as a default dependency in #244. If you pixi add x it is added to the default feature.

This doesn't really have any consequences but is simpler to use and understand, and more in line with Deltares/Ribasim#2024.

Best done after #244.
@visr visr self-assigned this Feb 4, 2025
@visr visr mentioned this issue Feb 6, 2025
Merged
visr added a commit that referenced this issue Feb 6, 2025
@visr
Pixi: use default instead of common (#249)
0425171 
And remove last 3 notebooks, that were already converted.
Fixes #247
@visr visr closed this as completed in #249 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@visr visr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pixi: use default instead of common Deltares/Ribasim-NL
1 participant
@visr