Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "method_complexity" issue in CODE/_dev.py #88

Closed
DefinetlyNotAI opened this issue Sep 5, 2024 · 0 comments · Fixed by #90
Closed

Fix "method_complexity" issue in CODE/_dev.py #88

DefinetlyNotAI opened this issue Sep 5, 2024 · 0 comments · Fixed by #90
Assignees
@DefinetlyNotAI
Labels
bug/Low Something isn't working, it's simple though. type/Code Related to the Code part type/Documentation Improvements or additions to commentations
Milestone
Bugs and Issues

Comments

@DefinetlyNotAI
Copy link
Owner

Function check_current_files has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.

https://codeclimate.com/github/DefinetlyNotAI/Logicytics/CODE/_dev.py#issue_66d9650fe36f970001000024
@DefinetlyNotAI DefinetlyNotAI moved this to Todo in Issue Board Sep 5, 2024
@DefinetlyNotAI DefinetlyNotAI self-assigned this Sep 5, 2024
@DefinetlyNotAI DefinetlyNotAI added bug/Low Something isn't working, it's simple though. type/Documentation Improvements or additions to commentations and removed Need Admin labels Sep 5, 2024
@DefinetlyNotAI DefinetlyNotAI moved this from Todo to Done in Issue Board Sep 6, 2024
@DefinetlyNotAI DefinetlyNotAI mentioned this issue Sep 6, 2024
Merged
11 tasks
@DefinetlyNotAI DefinetlyNotAI linked a pull request Sep 6, 2024 that will close this issue
Patch #90
Merged
11 tasks
DefinetlyNotAI added a commit that referenced this issue Sep 6, 2024
@DefinetlyNotAI
Patch (#90)
da5a65f 
## Pull Request Template

### Prerequisites

<!-- Take a couple minutes to help our maintainers work faster by
checking of the pre-requisites. -->

- [x] I have
[searched](https://github.com/DefinetlyNotAI/Logicytics/pulls) for
duplicate or closed issues.
- [x] I have read the [contributing
guidelines](https://github.com/DefinetlyNotAI/Logicytics/blob/main/CONTRIBUTING.md).
- [x] I have followed the instructions in the
[wiki](https://github.com/DefinetlyNotAI/Logicytics/wiki) about
contributions.
- [x] I have updated the documentation accordingly, if required.
- [ ] I have added tests to cover my changes, and they have passed, if
required.
- [x] I have tested my code with the `--dev` flag, if required.

### PR Type

<!-- Take a couple minutes to help our maintainers work faster by
telling us what is the PR guided on. -->

- [ ] Bug fix <!-- Non-Breaking Bug Fix - Usually relates to fixing an
issue -->
- [ ] New feature <!-- Non-Breaking Change that adds a new feature -->
- [x] Refactoring <!-- Non-Breaking Change that modifies existing code
to refactor it to become more organised -->
- [ ] Documentation update <!-- Non-Breaking Change that modifies
existing documentation to refactor it or add extra commentation - either
wiki, md files or code is included here -->
- [ ] ⚠️ Breaking change ⚠️ <!-- ⚠️ Breaking Bug Fix / New Addition that
changes how Logicytics works ⚠️-->

### Description

Basic fixes suggested from issues (CodeCademy)

### Motivation and Context

Many things

### Issues Fixed

#89 #63 #80 #81 #82 #85 #86 #88 #78 #79 #65
@DefinetlyNotAI DefinetlyNotAI added the type/Code Related to the Code part label Sep 18, 2024
@DefinetlyNotAI DefinetlyNotAI added this to the Bugs and Issues milestone Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DefinetlyNotAI DefinetlyNotAI

Labels
bug/Low Something isn't working, it's simple though. type/Code Related to the Code part type/Documentation Improvements or additions to commentations
Projects
Issue Board
Status: Done
Milestone
Bugs and Issues
Development

Successfully merging a pull request may close this issue.

Patch DefinetlyNotAI/Logicytics
1 participant
@DefinetlyNotAI