Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor compatibility fixes for PySide6==6.4.2 #115

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Minor compatibility fixes for PySide6==6.4.2 #115

merged 2 commits into from
Feb 19, 2024

Conversation

jeylau
Copy link
Contributor

@jeylau jeylau commented Feb 13, 2024

Beyond the test for a checkbox state that needed a fix, I couldn't spot anything else; the GUI is functional. It looks to me like we're good to go for an upgrade of PySide6.

@jeylau jeylau added the enhancement New feature or request label Feb 13, 2024
@jeylau jeylau requested a review from n-poulsen February 13, 2024 20:19
Copy link
Collaborator

@n-poulsen n-poulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good to me. I would just also change the setup.cfg to specify:

[options.extras_require]
testing =
    ...
    pyside6==6.4.2

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fa2145c) 81.87% compared to head (cfa84b6) 81.87%.

Files Patch % Lines
src/napari_deeplabcut/_widgets.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   81.87%   81.87%           
=======================================
  Files          11       11           
  Lines        1754     1754           
=======================================
  Hits         1436     1436           
  Misses        318      318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n-poulsen n-poulsen self-requested a review February 19, 2024 14:06
@MMathisLab MMathisLab merged commit 26a8e19 into main Feb 19, 2024
@jeylau jeylau deleted the compat_fixes branch February 19, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants