fix video len bug #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlc2nwb/utils.py
Outdated
| @@ -195,6 +198,7 @@ def _write_pes_to_nwbfile( | |||
| paf_graph, | |||
| timestamps, | |||
| exclude_nans, | |||
| **optional_kwargs, | |||
There was a problem hiding this comment.
Suggested change
| **optional_kwargs, | |
| **optional_container_kwargs, |
or optional_pose_estimation_kwargs to distinguish these from ones you would pass to individual series
Also might just be better to make it fully explicit with pose_estimation_container_kwargs: Optional[dict] = None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue raised in #22.
I've started the PR to make sure I'm not contributing code in the wrong place. I'm fixing some other issues arising as the result of relying on this library from
neuroconv(eg, alsoAttributeError: 'cv2.VideoCapture' object has no attribute 'fps', line 85)