Refactor ann and unet #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all folders, ann, attention, and TL
… Load one input checkpoints, infer, return output.
…n UNet. Not implemented for TL so far.
… Attention UNets, and Transfer Learning
…ning. Also made modifications related to logging and argparsing as suggested by Tom
…nd anns. Need to resolve the argparsing cyclic dependence still.
TomMelt
reviewed
Jan 23, 2025
…d inference files for both types of models and for inference for both ERA5 and IFS.
…tory: iccs_coupling_checkpoints
TomMelt
reviewed
Jan 29, 2025
TomMelt
reviewed
Jan 29, 2025
amangupta2
commented
Jan 29, 2025
There was a problem hiding this comment.
@TomMelt Yes, this looks good. These files have now been moved to ../utils/ so they can be deleted. I somehow missed these during the last commit.
TomMelt
reviewed
Jan 30, 2025
TomMelt
reviewed
Jan 30, 2025
TomMelt
reviewed
Jan 30, 2025
TomMelt
approved these changes
Feb 5, 2025
This was referenced Feb 5, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of PR #34 and #30
No work has been done wrt #30 yet. However, all suggestions in #34 have now been implemented for both era5_training and ifs_transfer_learning.
Another folder era5_training is created to replace the two folders ann_cnn_training and attention_net. All the supporting function definitions have been moved to the newly created utils folder. The code is not fully ready yet as I am still working on merging the training for both the models into a single file.