Adding JMX support to e2e tests #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vickenty
approved these changes
Nov 15, 2024
pducolin
reviewed
Nov 15, 2024
carlosroman
force-pushed
the
carlosroman/AMLII-1076-adding-JMX-support-to-e2e-tests
branch
from
3466bcf to
5929c82
Compare
carlosroman
force-pushed
the
carlosroman/AMLII-1076-adding-JMX-support-to-e2e-tests
branch
from
5929c82 to
f6b9625
Compare
pducolin
approved these changes
Nov 21, 2024
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-mergequeue
bot
deleted the
carlosroman/AMLII-1076-adding-JMX-support-to-e2e-tests
branch
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds support to be able to use the JMX container version of the Agent in e2e tests.
Which scenarios this will impact?
Just AML tests.
Motivation
I'd like to not have to manually test JMXFetch changes.
Additional Notes
Have also updated the JMXFetch sample app with some helper manifests to allow JMXFetch to grab metrics.