Class structure update #9
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ues. More debugging is needed
…ations.py) that contains simulation constants and labels for permeability, model type, resevoir geometry, polymer list, and surfactant list
… Also updated the compvis function within the simulation.py python file
…simulation' class
…unction to solve the transport equations.
…ionality of the simulation, polymer, and surfactant classes
…on the simulation class within simulation.py
…345/Surfactant-Polymer-Flooding-Modeling into class_structure_update
…test function for the z_func_test().
…ction definitions for test cases) and also added a few methods within the simulation class (also need to add function definitions here)
… simulation class
…Also, continuing to work on adding the saturation_equ_solver() method
It is a helper function to the saturation_equation_solver() method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented the class structure with a polymer, surfactant, and overall simulation class. The polymer and surfactant classes don't have any methods; they simply store the properties (such as concentration) of the substances used within the simulation. The simulation class holds all the methods used when the simulation is running.
I think it would be a good idea to review the class structure and see if there are things that should be moved before merging it into the development branch. We can discuss this during our meeting on November 10th. In the meantime, please review the code changes and provide comments on what should be changed, or go ahead and make those changes :).