From 715ff10abc6b658a73771cf2d32a92f3c148c44e Mon Sep 17 00:00:00 2001 From: Tri Dao Date: Fri, 6 Dec 2024 01:06:58 -0800 Subject: [PATCH] [CI] Change torch 2.6.0.dev20241010 to dev20241001 for nvcr 24.11 --- .github/workflows/publish.yaml | 10 ++++++---- causal_conv1d/__init__.py | 2 +- setup.py | 4 ++-- 3 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index cb7561d..4ba3846 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -45,7 +45,7 @@ jobs: os: [ubuntu-20.04] python-version: ['3.9', '3.10', '3.11', '3.12', '3.13'] torch-version: ['2.1.2', '2.2.2', '2.3.1', '2.4.0', '2.5.1', '2.6.0.dev20241010'] - cuda-version: ['11.8.0', '12.4.1'] + cuda-version: ['11.8.0', '12.3.2'] # We need separate wheels that either uses C++11 ABI (-D_GLIBCXX_USE_CXX11_ABI) or not. # Pytorch wheels currently don't use it, but nvcr images have Pytorch compiled with C++11 ABI. # Without this we get import error (undefined symbol: _ZN3c105ErrorC2ENS_14SourceLocationESs) @@ -80,6 +80,7 @@ jobs: echo "MATRIX_CUDA_VERSION=$(echo ${{ matrix.cuda-version }} | awk -F \. {'print $1 $2'})" >> $GITHUB_ENV echo "MATRIX_TORCH_VERSION=$(echo ${{ matrix.torch-version }} | awk -F \. {'print $1 "." $2'})" >> $GITHUB_ENV echo "WHEEL_CUDA_VERSION=$(echo ${{ matrix.cuda-version }} | awk -F \. {'print $1'})" >> $GITHUB_ENV + echo "MATRIX_PYTHON_VERSION=$(echo ${{ matrix.python-version }} | awk -F \. {'print $1 $2'})" >> $GITHUB_ENV - name: Free up disk space if: ${{ runner.os == 'Linux' }} @@ -106,8 +107,6 @@ jobs: # default method is "local", and we're hitting some error with caching for CUDA 11.8 and 12.1 # method: ${{ (matrix.cuda-version == '11.8.0' || matrix.cuda-version == '12.1.0') && 'network' || 'local' }} method: 'network' - # We need the cuda libraries (e.g. cuSparse, cuSolver) for compiling PyTorch extensions, - # not just nvcc sub-packages: '["nvcc"]' - name: Install PyTorch ${{ matrix.torch-version }}+cu${{ matrix.cuda-version }} @@ -127,7 +126,10 @@ jobs: print(minv if int(env['MATRIX_CUDA_VERSION']) < 120 else maxv)" \ ) if [[ ${{ matrix.torch-version }} == *"dev"* ]]; then - pip install --no-cache-dir --pre torch==${{ matrix.torch-version }} --index-url https://download.pytorch.org/whl/nightly/cu${TORCH_CUDA_VERSION} + # pip install --no-cache-dir --pre torch==${{ matrix.torch-version }} --index-url https://download.pytorch.org/whl/nightly/cu${TORCH_CUDA_VERSION} + # --no-deps because we can't install old versions of pytorch-triton + pip install jinja2 + pip install --no-cache-dir --pre https://download.pytorch.org/whl/nightly/cu${TORCH_CUDA_VERSION}/torch-${{ matrix.torch-version }}%2Bcu${TORCH_CUDA_VERSION}-cp${MATRIX_PYTHON_VERSION}-cp${MATRIX_PYTHON_VERSION}-linux_x86_64.whl else pip install --no-cache-dir torch==${{ matrix.torch-version }} --index-url https://download.pytorch.org/whl/cu${TORCH_CUDA_VERSION} fi diff --git a/causal_conv1d/__init__.py b/causal_conv1d/__init__.py index 2182dc3..7b4376f 100644 --- a/causal_conv1d/__init__.py +++ b/causal_conv1d/__init__.py @@ -1,3 +1,3 @@ -__version__ = "1.5.0.post5" +__version__ = "1.5.0.post6" from causal_conv1d.causal_conv1d_interface import causal_conv1d_fn, causal_conv1d_update diff --git a/setup.py b/setup.py index d458196..ce3fb62 100644 --- a/setup.py +++ b/setup.py @@ -267,9 +267,9 @@ def get_wheel_url(): # We're using the CUDA version used to build torch, not the one currently installed # _, cuda_version_raw = get_cuda_bare_metal_version(CUDA_HOME) torch_cuda_version = parse(torch.version.cuda) - # For CUDA 11, we only compile for CUDA 11.8, and for CUDA 12 we only compile for CUDA 12.4 + # For CUDA 11, we only compile for CUDA 11.8, and for CUDA 12 we only compile for CUDA 12.3 # to save CI time. Minor versions should be compatible. - torch_cuda_version = parse("11.8") if torch_cuda_version.major == 11 else parse("12.4") + torch_cuda_version = parse("11.8") if torch_cuda_version.major == 11 else parse("12.3") cuda_version = f"{torch_cuda_version.major}" gpu_compute_version = hip_version if HIP_BUILD else cuda_version