fix: non string hook id breaks router

DanielSharkov · Feb 11, 2022 · f842ada · f842ada
1 parent 9c0088f
commit f842ada
Show file tree

Hide file tree

Showing 4 changed files with 1,195 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -308,7 +308,9 @@ Simple example of using a hook:
 	import {onDestroy} from 'svelte'
 	import router from './router'
 
+	const testHookID = 'test-hook'
 	const removeBeforePushHook = router.addBeforePushHook(
+		testHookID,
 		({location, pendingRoute, resolve, reject})=> {
 			if (pendingRoute.name === '/very/secret/path') {
 				reject()
@@ -319,6 +321,8 @@ Simple example of using a hook:
 
 	onDestroy(()=> {
 		removeBeforePushHook()
+		// or
+		// router.removeBeforePush(testHookID)
 	})
 </script>
 ```