crnlib: don't stop listing files if there is an unknown file type in a directory, skip it #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a directory, skip it Co-authored-by: DolceTriade <vcelestialragev@gmail.com>
|
We may have a more generic thinking about what we want there, for example, we may still want to accept some character file so we can convert files by piping them through But this patch is enough to fix the related bug, where a file cannot be converted because there is a fifo in the same folder. |
DolceTriade
reviewed
Sep 26, 2024
illwieckz
force-pushed
the
illwieckz/continue-unknown-filetype
branch
from
af6331a
to
27a15c6
Compare
DolceTriade
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't stop listing files if there is an unknown file type in a directory, skip it.