Skip to content
This repository has been archived by the owner on Aug 15, 2023. It is now read-only.

appId vs domains #6

Open
DaWe35 opened this issue Nov 3, 2020 · 3 comments
Open

appId vs domains #6

DaWe35 opened this issue Nov 3, 2020 · 3 comments

Comments

@DaWe35
Copy link
Owner

DaWe35 commented Nov 3, 2020

the example is confusing me because it named itself 'example-skapp' instead of 'skyacc'
also, it should talk about domains rather than the application itself
the text should probably read
"skyacc is requesting access to the domain 'example-domain', do you wish to give it access?"
and then probably a '?' button somewhere that explains what domains are and why apps need permissions to them and what the potential consequences are of giving permissions to a bad guy
maybe some text like
"Skynet applications can request access to different domains. If you give an application access to a domain, it can overwrite any data inside of the domain. This means a malicious app can potentially delete your data if you grant it permission. Applications can only access the domains you grant them access to. So for example, a note taking app might request access to the domain "notes". A different app which requests access to the "videos" domain will not be able to modify any of the data in the "notes" domain."

@vbylen
Copy link
Contributor

vbylen commented Nov 6, 2020

Also a little confusing is that you have to 'grant access' every time you login.

Normally I'd expect that you only have to grant access once.

image

@BryantS11
Copy link

When you sign in with facebook, it lets you know that you have signed in with that website before. It then asks if you would like to continue and sign in.

This would be great for SkyID as it would cut down on phishing and let users know that it is the correct place that they are signing into.

@DaWe35
Copy link
Owner Author

DaWe35 commented Nov 7, 2020

Sure, it is possible to log in users without asking to access if `dapp url' == 'saved origin dapp url'. Makes sense!

@DaWe35 DaWe35 closed this as completed in e40523f Nov 13, 2020
@DaWe35 DaWe35 reopened this Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants