Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple months ago, I made a PR (#629) to remove the requirement for brewing a vanilla potion from all of the spectrum potion recipes. It was denied, on the grounds that dumping the entire Potion Workshop system on new players at once would be overwhelming, which is a fairly valid point.
However, the problem that PR would have solved is still a thing, and we're still getting people in the questions channel who've beaten the entire main progression but don't know how to unlock potions. After discussing this issue with a couple other devs (conversation starts here) I believe we've come up with a solution that fixes the "how do I unlock potions?" issue without making the system too overwhelming for newbies.
This PR removes the brew-a-potion requirement from the spectrum potion recipes, just like the previous one did. However, it also adds that advancement as a requirement for all of the custom reagents added by Spectrum. After all, the reagent system is the most complex part of the Potion Workshop's mechanics, so if we're trying to reduce information overload that seems like the best thing to temporarily lock off.
When the Potion Workshop is first unlocked, players will have access to all of the custom spectrum potions whose ingredients they've unlocked, and the reagents entry will contain only the 3/4 vanilla ones (redstone, glowstone, gunpowder, and potentially dragon's breath). The opening pages of the entry will look like this:
Once the player brews a potion using the Workshop, all of the custom reagents added by Spectrum will unlock. This will also cause page 2 to appear at the beginning of the reagents entry, describing how the new reagents can interact with each other:
This way, the flood of information for new players is significantly reduced, without the current issue of removing any incentive to actually use Spectrum's potion mechanics and thus discover the rest of the content.
This PR also makes locked reagent recipes actually act locked. Previously, if a reagent recipe was locked it would display as such in your recipe viewer, but putting the item into the Potion Workshop would work totally fine.