FFS-2466: Infer supported jobs from within Pinwheel subclass #474
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Addresses FFS-2466.
Changes
This makes the model infer the pinwheel accounts supported jobs through the provided pinwheel_account_id.
Context for reviewers
We need to do this to make it easier to support multi-provider. The reason for this is that we want to create a payrol_acount earlier in the process, not when the webhook is received. In order to do that, we needed a tidier way to create payroll account objects.
Before, we would look up the support jobs in the events controller and provide that to the model.
Now, we do that in an after_create hook. This means we can create payroll acounts anywhere without also needing to supply the supported jobs.
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!
)