Session extension modal properly appears after 5 seconds (for develop… #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment purposes), need to work on extending the actual session
Comment on lines
95
to
111
| const trigger = document.createElement('a') | ||
| trigger.id = 'session-timeout-trigger' | ||
| trigger.href = '#cbv-session-timeout-content' | ||
| trigger.className = 'usa-button' | ||
| trigger.setAttribute('aria-controls', 'cbv-session-timeout-content') | ||
| trigger.dataset.openModal = true // Set to true instead of empty string | ||
| trigger.textContent = 'Open Session Timeout Modal' | ||
|
|
||
| // Add to DOM in a visible location | ||
| const container = document.createElement('div') | ||
| container.style.position = 'fixed' | ||
| container.style.top = '20px' | ||
| container.style.right = '20px' | ||
| container.style.zIndex = '9999' | ||
| container.appendChild(trigger) | ||
| document.body.appendChild(container) | ||
| console.log('Created modal trigger:', trigger) |
There was a problem hiding this comment.
I would try to put these in the layout template instead of creating/tearing down each time. There are turbo features for selecting stuff like this!
There was a problem hiding this comment.
For sure! This is preliminary stuff used for development, but if we opt to use a hidden button then I'll be sure to move it to the template.
app/app/javascript/controllers/cbv/sessions/timeout_controller.js
Outdated
Show resolved
Hide resolved
…r activity and extend or cancel the session
…the session now, might have to implement a controller for that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves FFS-2377.
Changes
Context for reviewers
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)