Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FFS-1427: Implement: Error page for 404/500 errors #462

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

tdooner
Copy link
Contributor

@tdooner tdooner commented Feb 20, 2025

Ticket

Resolves FFS-1427.

Changes

FFS-1427: Implement custom 404/500 errors

Context for reviewers

Acceptance testing

  • No acceptance testing needed
    • This change will not affect the user experience (bugfix, dependency updates, etc.)
  • Acceptance testing prior to merge
    • This change can be verified visually via screenshots attached below or by sending a link to a local development environment to the acceptance tester
    • Acceptance testing should be done by design for visual changes, product for behavior/logic changes, or both for changes that impact both.
  • Acceptance testing after merge
    • This change is hard to test locally, so we'll test it in the demo environment (deployed automatically after merge.)
    • Make sure to notify the team once this PR is merged so we don't inadvertently deploy the unaccepted change to production. (e.g. :alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)

@@ -21,3 +21,5 @@ Layout/IndentationWidth:
Layout/IndentationConsistency:
Enabled: true
EnforcedStyle: normal
Layout/EndAlignment:
EnforcedStyleAlignWith: keyword
Copy link
Contributor Author

@tdooner tdooner Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is to allow:

@cbv_flow = if session[:cbv_flow_id]
              CbvFlow.find(session[:cbv_flow_id])
            end

@tdooner
Copy link
Contributor Author

tdooner commented Feb 20, 2025

404 after having started a CBV flow:
image

404 in a new window/incognito:
Screenshot 2025-02-19 at 4 57 10 PM

500:
image

@tdooner tdooner force-pushed the td/ffs-1427-implement-error-page-404 branch 8 times, most recently from 0aea613 to 5f8c921 Compare February 21, 2025 19:17
@tdooner tdooner force-pushed the td/ffs-1427-implement-error-page-404 branch from 5f8c921 to 14f4f53 Compare February 21, 2025 19:27
@@ -1,3 +0,0 @@
network.globalExclusions.exclusions(0).exclusion.name=Search
network.globalExclusions.exclusions(0).exclusion.enabled=true
network.globalExclusions.exclusions(0).exclusion.value=/.*\/(?:.{2}\/)?cbv\/employer_search\?authenticity\_token.*/gm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We previously had this config to exclude /cbv/employer_search from our CSP checks. But it doesn't seem necessary anymore (or else the owasp-zap action would have failed after I removed it.)

@tdooner tdooner marked this pull request as ready for review February 21, 2025 19:36
@tdooner
Copy link
Contributor Author

tdooner commented Feb 22, 2025

Sam acceptance-tested and approved via Slack!

@tdooner tdooner merged commit ab90d33 into main Feb 22, 2025
22 checks passed
@tdooner tdooner deleted the td/ffs-1427-implement-error-page-404 branch February 22, 2025 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants