-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFS-1427: Implement: Error page for 404/500 errors #462
Conversation
@@ -21,3 +21,5 @@ Layout/IndentationWidth: | |||
Layout/IndentationConsistency: | |||
Enabled: true | |||
EnforcedStyle: normal | |||
Layout/EndAlignment: | |||
EnforcedStyleAlignWith: keyword |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is to allow:
@cbv_flow = if session[:cbv_flow_id]
CbvFlow.find(session[:cbv_flow_id])
end
0aea613
to
5f8c921
Compare
5f8c921
to
14f4f53
Compare
@@ -1,3 +0,0 @@ | |||
network.globalExclusions.exclusions(0).exclusion.name=Search | |||
network.globalExclusions.exclusions(0).exclusion.enabled=true | |||
network.globalExclusions.exclusions(0).exclusion.value=/.*\/(?:.{2}\/)?cbv\/employer_search\?authenticity\_token.*/gm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We previously had this config to exclude /cbv/employer_search from our CSP checks. But it doesn't seem necessary anymore (or else the owasp-zap
action would have failed after I removed it.)
Sam acceptance-tested and approved via Slack! |
Ticket
Resolves FFS-1427.
Changes
FFS-1427: Implement custom 404/500 errors
Context for reviewers
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!
)