Upgrade nokogiri 1.17.2 -> 1.18.3 #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdooner
force-pushed
the
td/upgrade-nokogiri
branch
2 times, most recently
from
b92a612 to
dfdd3fb
Compare
I broke these out into a separate Dockerfile section to be explicit about the reason we're installing them.
tdooner
force-pushed
the
td/upgrade-nokogiri
branch
from
dfdd3fb to
9d1dc75
Compare
|
Going to self-merge since it is breaking the build and hopefully the Dockerfile change is uncontroversial. Happy to revert if someone finds it weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CVE-2025-24928 and CVE-2024-56171.