-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FFS-2492: store applicant id in session, use it when logging events as the dist… #460
base: main
Are you sure you want to change the base?
Conversation
@@ -90,6 +90,7 @@ def capture_page_view | |||
event_logger.track("CbvPageView", request, { | |||
cbv_flow_id: @cbv_flow.id, | |||
invitation_id: @cbv_flow.cbv_flow_invitation_id, | |||
cbv_applicant_id: @cbv_flow.cbv_applicant_id, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this work if the vast majority of the mixpanel events don't have the cbv_applicant_id
field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it wouldn't. Maybe I'm misunderstanding how the applicant id works. I assumed that all people going through the cbv flow would have one, invited or not. But if that's not the case then maybe I should fall back to a distinct ID of "invite-#" when applicant ID is missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified all the events have the applicant id
FFS-2492
Changes
Use applicant ID as distinct ID on Mixpanel
Testing Instructions
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!
)