Initial infrastructure setup from George #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one-time rails_master_key env to image
…move other env log files
Puma writes its pid to a temporary pidfile in ./tmp/pids by default, however, this was a problem because we were mounting the whole filesystem as readonly. To allow for creation of this pid file and whatever else Rails needs that tmp directory for, let's mount it in as an ephemeral volume from Fargate. This commit also includes some README changes to reflect my experience getting terraform and docker running on my laptop.
This is necessary (and it has to be after the `USER` declaration) or else the `rails` user won't be able to write files in there.
* origin/main: Fix rubocop action by installing gems first Fix rubocop Github Action specification Add comments field to "summary" page Bring in UswdsFormBuilder Configure ngrok and Argyle webhooks automatically Remove unused constants Upgrade rexml 3.2.6 -> 3.2.8 Add Github action to run rubocop Revert "Update app/controllers/cbv_flows_controller.rb" Update app/controllers/cbv_flows_controller.rb Redirect if cbv flow isn’t found Reuse an associated CbvFlow if it exists Autocorrect all Rubocop lints Generate Tokenized Links for Invitations Fix assertions and implicitly parse JSON Move into helper module Rework tests Rework testing approach Implement in API Implement service class Create ArgyleService class
* Run actions only conditionally if the cbv app is changed
* Upgrade github-script v4 -> v7 since it's on Node 20 * Use relative path starting with "./" to satisfy actionlint
Ignore a lot of package pinning warnings since the packages are not likely to break our app if the version shifts slightly, and in fact, it may be more secure to have the latest updates.
This is necessary to build the docker image under Github actions, apparently. According to: https://github.com/DSACMS/iv-cbv-payroll/actions/runs/9182186907/job/25250566269?pr=29#step:4:3704
These actions don't work in our new directory structure, and I would like to re-enable them later.
Apparently working-directory is for `run` commands only?
There was an issue with the original .gitignore that led to these cache files being committed by accident.
|
The commit history on this is... wild. I think someone committed a node_modules directory or something. I'd like to start a new branch and just apply the current state. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit history for initial infrastructure setup.
This PR can be merged, though it will be disruptive because it moves the entire Rails app into a
cbvsubfolder. For almost all development henceforth, we will have to be within that folder. You'll also have to move old non-git files into their right places:mv .env* cbv/So as to not keep this branch getting progressively bigger and bigger, let's break out the following infrastructure TODO's: