Use adaptive buckets for the submission graph #2944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
reviewed
Mar 2, 2025
| // We want whole values in the unit, and the ticks MUST match a corresponding bucket otherwise the resulting | ||
| // coordinate will be NaN. | ||
| const convert_factor = seconds_per_bucket / unit.convert; | ||
| const maxTicks = Math.min(bucket_count, contest_duration / unit.step, 31) |
There was a problem hiding this comment.
The idea was to limit the max number of ticks shown to some reasonable number. Changed it to the minimum bucket count as it looks pleasant.
We determine a suitable unit based on the contest length and some min/max bucket bounds. We convert all submission times in seconds to this unit and determine nice locations to put ticks on the x-axis.
Kevinjil
force-pushed
the
feature/analysis-buckets
branch
from
f7a3276 to
9619722
Compare
meisterT
approved these changes
Mar 2, 2025
nickygerritsen
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We determine a suitable unit based on the contest length and some min/max bucket bounds. We convert all submission times in seconds to this unit and determine nice locations to put ticks on the x-axis.
Scaling for e.g. 1-year contest:
Fixes #2934