Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the upload of the unit test results #2884

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Dec 21, 2024

We expect the file to be named per matrix job but this was not updated in the code so the upload action couldn't find the files.

First part to fix: #2879

@vmcj vmcj force-pushed the fix_unit_test_upload_gha branch from 9173b73 to ba6a32d Compare December 21, 2024 23:29
@vmcj vmcj force-pushed the fix_unit_test_upload_gha branch from ba6a32d to 7ae59f7 Compare December 22, 2024 10:53
See:
https://github.com/DOMjudge/domjudge/actions/runs/12247242151/job/34164708661?pr=2879

Here the push from dependabot failed to add the check-run results. Other
possible permissions:
https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#create-a-check-run

We expect the file to be named per matrix job but this was not updated
in the code so the upload action couldn't find the files.
@vmcj vmcj force-pushed the fix_unit_test_upload_gha branch from 7337ea1 to 687431c Compare February 26, 2025 20:08
@vmcj vmcj enabled auto-merge February 26, 2025 20:17
@vmcj vmcj added this pull request to the merge queue Feb 26, 2025
Merged via the queue into DOMjudge:main with commit 54665f8 Feb 26, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant