Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tiglExportComponent respect symmetries #1061

Conversation

rainman110
Copy link
Collaborator

@rainman110 rainman110 commented Feb 18, 2025

Description

This makes tiglExportComponent respect the symmetry option of tiglSetExportOptions, e.g.

tiglSetExportOptions("brep", "ApplySymmetries", "true");

such that a symmetric shape is exported if requested.

Before, only the asymmetric shape has been exported, ignoring the symmetry flag.

Note: This might break the behavior of client code that assumes non-symmetric geometries, even if the symmetry flag has been set.

Closes #1060

How Has This Been Tested?

Manually.

Screenshots, that help to understand the changes(if applicable):

Checklist:

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

Note, this might break the behaviour of client code that
assumes non-symmtric geometries, even if the symmetry flag
has been set.

Closes #1060
@rainman110 rainman110 linked an issue Feb 18, 2025 that may be closed by this pull request
@rainman110 rainman110 requested review from AntonReiswich and joergbrech and removed request for AntonReiswich February 18, 2025 08:50
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.50%. Comparing base (d46a3e8) to head (c653370).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1061   +/-   ##
=======================================
  Coverage   69.50%   69.50%           
=======================================
  Files         301      301           
  Lines       26912    26916    +4     
=======================================
+ Hits        18705    18709    +4     
  Misses       8207     8207           
Flag Coverage Δ
unittests 69.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/api/tigl.cpp 51.74% <100.00%> (+0.03%) ⬆️

Copy link
Contributor

@joergbrech joergbrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution :)

@joergbrech joergbrech merged commit 329d6ba into master Feb 19, 2025
17 checks passed
@joergbrech joergbrech deleted the 1060-make-symmetry-mirroring-available-in-tiglexportcomponent branch February 19, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make symmetry mirroring available in tiglExportComponent
2 participants