Improved Symbol Demangling #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes adds support for symbol demangling via
cxx_demangleon Windows and uses the improved symbol demangling in reading classnames from RTTI entries on all current targets.Known problems:
When running a modified
devel/scan-vtablesfor Windows under wine, a number of symbols fail demangling, all of which can be filtered out by excluding those belonging to std/Concurency. This can be automatically performed by checking if the end of the mangled name isstd@@orConcurrency@@.I have not discovered any further issues, but practical testing is likely a requirement.
Thank you to @ab9rf and @lethosor for their help with understanding particular issues that arose.