Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5061 fix: add missing pthread_mutexattr_init() #5082

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

dhthwy
Copy link
Contributor

@dhthwy dhthwy commented Dec 6, 2024

Initialize attributes before use. I believe this is the source of UB on Linux, which results in stochastic hangs. It is easily reproducable when launching from steam on my system.

Copy link
Member

@lethosor lethosor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't reproduce on my end, but looks correct

Copy link
Member

@ab9rf ab9rf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously required by the specification

@ab9rf ab9rf merged commit 6260f10 into DFHack:develop Dec 6, 2024
14 checks passed
@ab9rf
Copy link
Member

ab9rf commented Dec 6, 2024

additional changelog not required as this is just completing #5061 which hasn't been published yet

@dhthwy dhthwy deleted the pr5061fix branch December 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants