Fixed a bug where entries in groups not under control get deleted. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkmt-mmy
reviewed
Jan 24, 2024
| .AddressRules | ||
| .Where(x => x.Control.Value) | ||
| .Select(x => x.AddressableGroup.Name) | ||
| .ToArray(); |
There was a problem hiding this comment.
Editor機能なのであまり気にしなくてもいいかもしれませんがToHashSetにしておくと、Containsが高速になって良いかもしれません
There was a problem hiding this comment.
それは思ったんですが、開発環境がUnity2020.3なのでギリギリ使えなそうです！
There was a problem hiding this comment.
コンストラクタでやる手も一応あります
var controlGroupNamesEnumerable = _layoutRule
.AddressRules
.Where(x => x.Control.Value)
.Select(x => x.AddressableGroup.Name);
var controlGroupNames = new HashSet<string>(controlGroupNamesEnumerable);
hkmt-mmy
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control下にないグループのエントリが削除されてしまうバグを修正しました。
Related Issue: #53