Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sanitize node.textContent #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't sanitize node.textContent #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 4 additions & 32 deletions src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,10 @@ export function bionify() {

return (
'<bionify class="bionify-highlight">' +
word.slice(0, numBold) +
escapeHtml(word.slice(0, numBold)) +
"</bionify>" +
'<bionify class="bionify-rest">' +
word.slice(numBold) +
escapeHtml(word.slice(numBold)) +
"</bionify>"
);
}
Expand All @@ -122,42 +122,14 @@ export function bionify() {
var entityMap = {
"&": "&amp;",
"<": "&lt;",
">": "&gt;",
'"': "&quot;",
"'": "&#39;",
"/": "&#x2F;",
"`": "&#x60;",
"=": "&#x3D;",
};

function escapeHtml(string) {
return String(string).replace(/[&<>"'`=\/]/g, function (s) {
return String(string).replace(/[&<]/g, function (s) {
return entityMap[s];
});
}

function htmlUnescape(str) {
return str
.replace(/&amp;/g, "&")
.replace(/&quot;/g, '"')
.replace(/&#39;/g, "'")
.replace(/&lt;/g, "<")
.replace(/&gt;/g, ">")
.replace(/&#x2F/g, "/")
.replace(/&#x3D;/g, "=")
.replace(/&#x60;/g, "`");
}

function sanitize(unsafe_str) {
return unsafe_str
.replace(/&/g, "&amp;")
.replace(/</g, "&lt;")
.replace(/>/g, "&gt;")
.replace(/\"/g, "&quot;");
// .replace(/\'/g, "&#39;");
// .replace(/\//g, "&#x2F;");
}

function bionifyifyNode(node) {
if (
node.tagName === "SCRIPT" ||
Expand All @@ -168,7 +140,7 @@ export function bionify() {
if (node.childNodes == undefined || node.childNodes.length == 0) {
if (node.textContent != undefined && node.tagName == undefined) {
var newNode = document.createElement("bionify");
newNode.innerHTML = bionifyifyText(sanitize(node.textContent));
newNode.innerHTML = bionifyifyText(node.textContent);
if (node.textContent.length > 20) {
node.replaceWith(newNode);
}
Expand Down