[BUG] Possible deadend in curtinfrc::Elevator::OnStatePeriodic

[met4000]

2019-DeepSpace/common/src/main/cpp/Elevator.cpp

Lines 96 to 107 in 750a48b

	// Limiters
	if (_config.limitSensorTop != nullptr)
	if (voltage > 0)
	if (_config.limitSensorTop->Get())
	voltage = 0;
	if (_config.limitSensorBottom != nullptr)
	if (voltage < 0)
	if (_config.limitSensorBottom->Get()) {
	voltage = 0;
	GetConfig().spool.encoder->ZeroEncoder();
	}

Potential problem with an elevator in kMoving attempting to reach an encoder value 'above' or 'below' the upper/lower limit switches (respectively), and never reaching the target value. Maybe instead of voltage = 0, SetManual(0) or SetHold() could be used, or some sort of 'out of bounds' error/feedback could be given?