Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: floating point error, switching to int values instead of float ones #1196

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

Mr666dd
Copy link

@Mr666dd Mr666dd commented Feb 28, 2025

I started working on changing the system: credits in users is now an integer; I changed Products, and the entire panel is actively changing. For all questions, suggestions and changes, I am open to your suggestions. Thanks!

@S0ly S0ly requested review from IceToast, 1day2die and S0ly and removed request for IceToast February 28, 2025 13:32
@Mr666dd
Copy link
Author

Mr666dd commented Mar 1, 2025

Can someone leave a review of the current code?

@LakshmiBhaskarPVL
Copy link

Can someone leave a review of the current code?

just for my curiosity, did you use ai?

@S0ly S0ly added the High Priority Critical. Act quickly for resolution label Mar 2, 2025
@S0ly
Copy link
Member

S0ly commented Mar 2, 2025

yes he seems to do, you two are doing the same error in the database migration
you need to understand where the error is coming from before trying to fix it

@Mr666dd
Copy link
Author

Mr666dd commented Mar 2, 2025

Can someone leave a review of the current code?

just for my curiosity, did you use ai?

Such an important system, payments, does not allow the use of artificial intelligence. Who knows what he might do; I only have the handwritten code and only with my own hands

@Mr666dd
Copy link
Author

Mr666dd commented Mar 2, 2025

yes he seems to do, you two are doing the same error in the database migration you need to understand where the error is coming from before trying to fix it

I don't understand what??
Dare I suggest that you first need to change the value, and then change the type in the table? Am I right? If so, I'll make changes to the migration.

@LakshmiBhaskarPVL
Copy link

there is only one problem with the database
Voucher Table -> Credits Type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority Critical. Act quickly for resolution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants