Fix error when we have multiple different map types #96
+921
−609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aykut-bozkurt
force-pushed
the
aykut/fix-multiple-maps-in-table
branch
from
6c12050 to
0fd5c99
Compare
aykut-bozkurt
force-pushed
the
aykut/fix-destreceiver-api
branch
from
f69bd74 to
71da48c
Compare
aykut-bozkurt
force-pushed
the
aykut/fix-multiple-maps-in-table
branch
from
0fd5c99 to
e37d709
Compare
aykut-bozkurt
force-pushed
the
aykut/fix-destreceiver-api
branch
from
71da48c to
30de679
Compare
aykut-bozkurt
force-pushed
the
aykut/fix-multiple-maps-in-table
branch
from
e37d709 to
1af44ab
Compare
marcoslot
reviewed
Jan 20, 2025
src/arrow_parquet/pg_to_arrow.rs
Outdated
| @@ -60,10 +60,10 @@ pub(crate) struct PgToArrowAttributeContext { | |||
| attnum: i16, | |||
| typoid: Oid, | |||
| typmod: i32, | |||
| map_typoid: Option<Oid>, | |||
There was a problem hiding this comment.
what's the difference with typeoid?
also, should this be some kind of enum?
There was a problem hiding this comment.
I was lazy to refactor pg-to-arrow and arrow-to-pg context structs. But, this seems a nice time to do it :)
aykut-bozkurt
force-pushed
the
aykut/fix-destreceiver-api
branch
2 times, most recently
from
f4264d4 to
54d4787
Compare
aykut-bozkurt
force-pushed
the
aykut/fix-multiple-maps-in-table
branch
from
1af44ab to
a9ffb66
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 92.65% 91.79% -0.86%
==========================================
Files 75 77 +2
Lines 9797 9981 +184
==========================================
+ Hits 9077 9162 +85
- Misses 720 819 +99 ☔ View full report in Codecov by Sentry. |
aykut-bozkurt
force-pushed
the
aykut/fix-multiple-maps-in-table
branch
from
a9ffb66 to
bf97833
Compare
marcoslot
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to reset map context per each type since each map type has different type oid.