Add fallback mechanism to convert unsupported PG types as arrow text array #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoslot
reviewed
Oct 2, 2024
| unsafe { | ||
| FALLBACK_TO_TEXT_CONTEXT | ||
| .set(FallbackToTextContext::new(typoid, typmod)) | ||
| .expect("failed to reset fallback_to_text context") |
There was a problem hiding this comment.
what happens if we have multiple types that fall back to text?
There was a problem hiding this comment.
we reset this for each type conversion. (not once per copy)
There was a problem hiding this comment.
hmz, ok, would be good to have more comments on the lifecycles of these contexts
aykut-bozkurt
force-pushed
the
crunchy-map-conversion
branch
from
1315215 to
d0a1773
Compare
aykut-bozkurt
force-pushed
the
fallback-type
branch
from
5521f97 to
18e6b64
Compare
|
Addressed at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.