Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[no-Jira] Improve test coverage #851

Merged
merged 5 commits into from
Jan 11, 2024
Merged

[no-Jira] Improve test coverage #851

merged 5 commits into from
Jan 11, 2024

Commits on Jan 4, 2024

  1. Add reviewRegistration controller tests

    @canac
    canac committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    8ec1664 View commit details
    Browse the repository at this point in the history

  2. Cleanup reviewRegistration controller 

    * Simplify allowGroupRegistration calculation
* Use an object for regValidate map
* Document non-existent properties
* Merge identical functions
* Simplify pageIsVisible check
    @canac
    canac committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ab9467f View commit details
    Browse the repository at this point in the history

  3. Add eventRegistrations tests

    @canac
    canac committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    beea6d6 View commit details
    Browse the repository at this point in the history

  4. Add eventForm tests

    @canac
    canac committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    fcaed37 View commit details
    Browse the repository at this point in the history

  5. Cleanup eventForm controller 

    * Remove unused dependency
* Remove redundant statement
* Improve makePositionArray readability
    @canac
    canac committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    6479121 View commit details
    Browse the repository at this point in the history