No-Jira Fix Campus

[caleballdrin]

Description

Students are submitting ERT forms with campuses that do not match the campus names in Infobase. This is because some browsers are auto-filling the campus data. The UI only validates when the user changes the field. So this bad data gets submitted.

Changes I made

• On page load, check if there is an answer already in the field. If there is, check to make sure that exists in the database with the searchCampuses() function. If it doesn't, set the answer to ''.
• Every time the UI validates the fields, include the campus question in that validation to make sure it is not empty.

[canac]

One stray comment, but it looks great! Good work with the tests too.

[canac]

Unless it's on purpose, you probably want to revert all your changes to package.json and yarn.lock. I believe that git checkout master -- package.json yarn.lock should do it.

[dr-bizz]

When testing on staging, my autofill still works. I was able to get to the final stage of the register form.

[caleballdrin]

@dr-bizz I haven't pushed it to staging yet. The On Staging label doesn't work for the ERT. I'm not sure why. It would be nice if it did.

[caleballdrin]

@dr-bizz It is on staging now.

[dr-bizz]

Just tested it again and this is still happening

[canac]

There's one more tweak we should make to the test. I think that if you use my suggestion, lines 257-258 will be hit by code coverage. We also might need a test with a non-empty campus answer in validateRegistrant.spec.js to cover line 343.

[canac]

Looks good now! 💯