-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New and updated model checks, improved XML export and bug fixes #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created mdde_IsMDDEDataSource criterium with template to be used from other objects to check data source is MDDE and refactored criteria for BaseClassifierMapping, BaseStructuralFeatureMapping, . Updated Entity AddMapping method to use constant for the MDDE DataSource Stereotype. Created mdde_Entity_IsBusinessRule extended attribute to be consumed by other extensions. Fixed naming error in criterium from mdde_BusinessRule_IsBusinessRuleWithMapping to mdde_BusinessRule_IsBusinessRuleWithoutMapping. Fixed ExtendedSubObject/mdde_EntityExampleData mdde_EntityExampleData_EditExampleEntity method so you can also make example data for business rules with mappings. Added mdde_ExampleValueCount on ExtendedSubObject/mdde_ExampleRecord, so it can be viewed in datagrid. Added force saving the model file as XML (in Model mdde_ExportXmlAndDecompose method) to the current location to solve issue of switching to binary model. XML Export: - Added sorting in XML export for Packages, ExampleRecord, Inheritence, DependentModels (in Model template). - Added Comment to XML export of BaseStructuralFeatureMapping. - Created mdde_IsAttributeMapped extended attribute on EntityAttribute (with logic on inheritance) and added to XML Export. - Updated EntityAttribute XML Export template to produce same XML output (and newlines) as before added export extension. - Added mdde_NamedObject_XmlElementExport_Template to Example XML export. - Enabled export of Comment and Description properties for all named objects (mdde_NamedObject_XmlElementExport_Template). Model checks: - BaseClassifierMapping - New: Check duplicate source objects (MDDE) - Updated: mdde_Check_OrderOFSourceObjects. - Business rule - Moved mdde_Check_BusinessRuleHasAtLeastOneInputAttribute and mdde_Check_BusinessRuleHasAtLeastOneExample to ExpressionBusinessRule, otherwise it wouldn't show up. - EntityAttribute: - Renamed mdde_Check_ScalarBusinessRule_AttributeCodeOccursInSqlExpression to mdde_Check_ExpressionBusinessRule_AttributeCodeOccursInSqlExpression. - ExtendedSubObject/mdde_EntityExampleData - New: Check Entity Example Data Attributes (MDDE) - ExtendedSubObject/mdde_SourceObject - New: Expression business rule join conditions are in same order as attributes (MDDE) - Updated: mdde_Check_JoinConditionSpecified: Added checking FROM object, coping with literals and better error handling. - ShortcutBase - New: Shortcut is broken (MDDE)
...eotypes/mdde_EntityExampleData/Custom_Checks/Check_Entity_Example_Data_Attributes_(MDDE).xml
Show resolved
Hide resolved
...ibute/Criteria/Criterion_AttributeIsInherited/Extended_Attributes/mdde_IsAttributeMapped.xml
Outdated
Show resolved
Hide resolved
...endedSubObject/Stereotypes/mdde_ExampleRecord/Extended_Attributes/mdde_ExampleValueCount.xml
Outdated
Show resolved
Hide resolved
...m_Checks/Expression_business_rule_join_conditions_are_in_same_order_as_attributes_(MDDE).xml
Outdated
Show resolved
Hide resolved
…rst record attribute.
Updated pdc ldm config to removed empty ExtendedCollections and ExtendedComposition elements.
willem-xbreeze
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XML Export:
Model checks:
Other changes: