Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axios thunk dumpster fire 👀 #19

Merged
merged 2 commits into from
Jul 1, 2020
Merged

axios thunk dumpster fire 👀 #19

merged 2 commits into from
Jul 1, 2020

Conversation

beetai
Copy link
Contributor

@beetai beetai commented Jul 1, 2020

naniiyeeeEEEEEEEEEEEEEEEEEEEEEEEEEEEeeeeet, 4 u

@beetai beetai requested review from baconandchips, DSep and yqj2k July 1, 2020 04:58
yqj2k
yqj2k reviewed Jul 1, 2020
View reviewed changes
server/routes/users.js Outdated
@@ -12,15 +12,16 @@ let users = [
id: '1',
username: 'testusername',
firstname: 'madman',
lastname: 'naniiyeeet'
lastname: 'naniiyeeeEEEEEEEEEEEEEEEEEEEEEEEEEEEeeeeet'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

DSep
DSep requested changes Jul 1, 2020
View reviewed changes
Copy link
Member

@DSep DSep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this, and the rest is good.

@beetai beetai merged commit 5237bae into develop Jul 1, 2020
@beetai beetai deleted the dev-btai-axios-thunk branch July 11, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yqj2k yqj2k yqj2k left review comments

@baconandchips baconandchips baconandchips approved these changes

@DSep DSep DSep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beetai @baconandchips @DSep @yqj2k