Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sam styles #18

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Sam styles #18

merged 3 commits into from
Jul 1, 2020

Conversation

yqj2k
Copy link
Contributor

@yqj2k yqj2k commented Jun 29, 2020

No description provided.

@yqj2k yqj2k requested review from DSep, baconandchips and beetai and removed request for DSep June 29, 2020 04:45

function App() {

const theme = useTheme();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this actually necessary here? Or is it something we need in each component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I committed the new change. I tested it locally, and it does not require useTheme.

Copy link
Contributor

@baconandchips baconandchips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's gooooooooo

@yqj2k yqj2k merged commit 547473c into develop Jul 1, 2020
@beetai beetai deleted the sam-styles branch July 11, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants