Sepand/browse separation and Course data type creation #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yqj2k
approved these changes
Jun 17, 2020
baconandchips
approved these changes
Jun 18, 2020
| changeFilters(searchInputs); | ||
| }; | ||
|
|
||
| return ( |
There was a problem hiding this comment.
Could suggest spacing out the page; the layout looks slightly cramped with too many buttons. Longer page may look better than compact page. Otherwise LGTM
There was a problem hiding this comment.
Nvm I was mistaken, LGTM
beetai
reviewed
Jun 18, 2020
| case SUBMIT_SEARCH: | ||
| return store; // TODO add actual behavious of searching | ||
| const another: string[] = store; | ||
| i += 1; |
beetai
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated Search and Results components from the Browse page.
Improved filters a bit.
Added Course data type and courseId operations.