Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eureka/contract info eureka port #622

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

jawoznia
Copy link
Contributor

No description provided.

@jawoznia jawoznia marked this pull request as ready for review February 14, 2025 15:09
@jawoznia jawoznia requested review from chipshort and pinosu February 14, 2025 15:09
@jawoznia jawoznia changed the base branch from main to feat/ibc_eureka February 14, 2025 15:17
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just wondering if we should catch that one edge case.

@jawoznia jawoznia requested a review from chipshort February 18, 2025 15:06
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@@ -402,6 +402,8 @@ type ContractInfoResponse struct {
Pinned bool `json:"pinned"`
// Set if the contract is IBC enabled
IBCPort string `json:"ibc_port,omitempty"`
// Set if the contract is Eureka enabled
EurekaPort string `json:"eureka_port,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this also needs to be added in cosmwasm-std.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Thanks for pointing this out

@jawoznia jawoznia merged commit 9282112 into feat/ibc_eureka Feb 19, 2025
15 checks passed
@jawoznia jawoznia deleted the eureka/contract-info-eureka-port branch February 19, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants