-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eureka/contract info eureka port #622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Just wondering if we should catch that one edge case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM
@@ -402,6 +402,8 @@ type ContractInfoResponse struct { | |||
Pinned bool `json:"pinned"` | |||
// Set if the contract is IBC enabled | |||
IBCPort string `json:"ibc_port,omitempty"` | |||
// Set if the contract is Eureka enabled | |||
EurekaPort string `json:"eureka_port,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this also needs to be added in cosmwasm-std.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. Thanks for pointing this out
No description provided.