Added rotation effect to cards #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
currently the flip animation is not proper, search about backface visibility and that will fix the issue
refer to this example : link
| @@ -91,6 +91,7 @@ function toggleSound(){ | |||
|
|
|||
| // unset image src when either card flip or show all cards | |||
| const unsetImgSource = (card) =>{ | |||
| flip(card) | |||
| card.children[0].src="#"; // Removing image src so that it isn't visible through HTML | |||
| card.children[0].alt="card front face"; // Removing image alt so that it isn't visible through HTML | |||
| card.children[1].style.display="block"; | |||
There was a problem hiding this comment.
hiding/unhiding the front pattern was temporary till this issue. Now after adding the rotation, there should be no need to hide/unhide it, as it should go backside.
so remove that
|
Thanks for the feedback @dev-lovedeep :-) I'll try fixing the issue. |
dev-lovedeep
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes so that the card appears to flip on clicking.