added a label wise difficulty #15
Conversation
hackeramitkumar
force-pushed
the
issue_label
branch
from
7bbc62c to
cb0462b
Compare
|
@dev-lovedeep Please review this PR and if any changes are required then let me know. |
hackeramitkumar
force-pushed
the
issue_label
branch
from
c876457 to
7faf6c1
Compare
|
@dev-lovedeep please review it. |
|
@hackeramitkumar you have done quite a work(will give you some extra points), but understand that you have putted everything using HTML. Let say in future we decide to change the number of cards in different levels, that would require you to change lots of things. A better approach would be to use JS to generate the cards(and also define no of cards as CONSTANTS ) and then append in HTML. Also use can resuse the already written code by passing a modified array depending upon the level and then the function will take care of things. |
|
@hackeramitkumar are you working on this issue? |
|
Sir actually I am out of station for next 3 days.
…On Mon, 3 Oct, 2022, 2:30 pm dev-lovedeep, ***@***.***> wrote:
@hackeramitkumar <https://github.com/hackeramitkumar> are you working on
this issue?
—
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASKPFGVWI2LLREFQLYMPECDWBKOBFANCNFSM6AAAAAAQ2Q2M7E>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
time for submitting PR will expire, see if you can complete it by today or I have to make this issue open again |
Fixes #6
I have added a prompt that will take difficulty as input. And according to that input the difficulty will be decided.
For easy -> 43 req_match -> 6
For Medium -> 45 req_match -> 10
For hard -> 4*7 req_match -> 14