Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check that debugger statements don't make it to published addon #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

armandoalonso
Copy link

This pull request adds validation on publish on ensure debugger statements don't end up in final build

image

Validate happens before and version update.

@skymen
Copy link
Contributor

skymen commented Jan 23, 2025

Can you make it check for debugger without ; and also how would you make sure it's not gonna mess with getDebuggerProperties or strings that contain the word?

Also I'm pretty sure debugger statements can be removed during the build step by rollup which I feel would be a better implementation.

Also, instead of failing it should have a buildconfig option that prints a warning instead

@armandoalonso
Copy link
Author

ill look into rollup removing those as it would be a much better solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants