Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply TypeScript rules for Vue code; use official nuxt/eslint package #45

Merged
merged 7 commits into from
Feb 18, 2025

Conversation

rudokemper
Copy link
Member

@rudokemper rudokemper commented Feb 18, 2025

Goal

Closes #44.

What I changed

  • Implemented proper use of the @nuxt/eslint module, since other packages were deprecated or not recommended with Nuxt 3.
  • Moved types.ts from server/ to its own root-level types/ directory, for usage across the repo.
  • Applied TypeScript rules to all vue script code, in so doing resolving loads of type errors - too many to enumerate, and the expectation is NOT that anyone would review them. Suffice to say that the TypeScript errors have gone away and that all non-trivial (e.g. not merely type related) changes have been tested manually in runtime or with vitest.

Note

Immediately upon merging this, I will add the commit to .git-blame-ignore-revs for readability sake.

@rudokemper rudokemper merged commit 7e1e80f into main Feb 18, 2025
1 check passed
@rudokemper rudokemper deleted the typescript-for-vue branch February 18, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply TypeScript to Vue code across repository
1 participant