Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make Init in libdecompressor thread safe #724

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Conversation

gbotrel
Copy link
Contributor

@gbotrel gbotrel commented Feb 24, 2025

Init was not protected by the lock which may cause issues in test settings.

@gbotrel gbotrel requested review from jpnovais and Tabaie February 24, 2025 14:27
@gbotrel gbotrel temporarily deployed to docker-build-and-e2e February 24, 2025 14:30 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.12%. Comparing base (45a41b4) to head (ebd378e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #724   +/-   ##
=========================================
  Coverage     68.12%   68.12%           
  Complexity     1182     1182           
=========================================
  Files           326      326           
  Lines         13219    13219           
  Branches       1337     1337           
=========================================
  Hits           9006     9006           
  Misses         3658     3658           
  Partials        555      555           
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <ø> (ø)
kotlin 65.77% <ø> (ø) Carriedforward from f4737c5

*This pull request uses carry forward flags. Click here to find out more.

@gbotrel gbotrel merged commit 41c8506 into main Feb 24, 2025
25 checks passed
@gbotrel gbotrel deleted the fix/decompressor/init branch February 24, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants