feat: support go corset optimisation and metadata #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
This adds support for passing a go-corset optimisation level via the bin/checker. The purpose of this is to enable testing at different optimisation levels to see what effect this has.
This exposes the metadata stored in the zkevm.bin file, such that it can be used for cross-checking purposes. For example, the metadata includes the git commit of the enclosing repository when it was built.
DavePearce
force-pushed
the
feat/allow-checker-to-configure-go-corset-optimisations
branch
from
31da448 to
6d90e47
Compare
DavePearce
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #713 +/- ##
=========================================
Coverage 68.40% 68.40%
Complexity 1185 1185
=========================================
Files 323 323
Lines 13131 13131
Branches 1319 1319
=========================================
Hits 8982 8982
Misses 3597 3597
Partials 552 552
*This pull request uses carry forward flags. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
(checker) Updates the checker to include the "full suite" when running in benchmark mode. This is relevant for testing to try and gauge total work done by the prover.
(optimisation) Adds the ability to specify the optimisation level that
go-corsetapplies when compiling thezkevm.binfile down to theair.Schemawhich is then consumed by the prover. In particular, thebin/checkeris updated to allow the optimisation level to be specified on the command-line for testing purposes. ADEFAULT_OPTIMISATION_LEVELis provided for normal use.(metadata) Exposes the metadata map which is stored within the
zkevm.binfile. This is a general purpose mechanism for embedding information within thezkevm.binfile. For example, it currently includes the git commit of the enclosing repository when thezkevm.binfile was built, and a timestamp. However, it could include other information as needed.