Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove reinit function in tokenbridge #670

Closed
wants to merge 1 commit into from

Conversation

kyzooghost
Copy link
Contributor

This PR implements issue(s) #664

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@kyzooghost kyzooghost requested a review from a team as a code owner February 11, 2025 09:47
@kyzooghost kyzooghost changed the title remove reinit function in tokenbridge [Refactor] Remove reinit function in tokenbridge Feb 11, 2025
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e February 11, 2025 09:48 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.43%. Comparing base (c083606) to head (7142489).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #670      +/-   ##
============================================
- Coverage     68.46%   68.43%   -0.03%     
  Complexity     1185     1185              
============================================
  Files           323      323              
  Lines         13130    13121       -9     
  Branches       1318     1316       -2     
============================================
- Hits           8989     8980       -9     
  Misses         3590     3590              
  Partials        551      551              
Flag Coverage Δ *Carryforward flag
hardhat 98.51% <ø> (-0.02%) ⬇️
kotlin 66.11% <ø> (ø) Carriedforward from c083606

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
contracts/src/bridging/token/TokenBridge.sol 100.00% <ø> (ø)

@kyzooghost
Copy link
Contributor Author

Closed as merged into #678

@kyzooghost kyzooghost closed this Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants