perf(prover): reduce synchronization allocs for FFT #668
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace channel-based synchronization with
sync.WaitGroup
.I think the primary reason is eliminating channel allocs in the recursive calls.
Benchmark results on M4 Pro show ~17% reduction in memory allocations (from ~8.2KB to ~6.7KB per operation) while ns/op remains similar.
Before
After