Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] OZ-Upgrade-Plugin + Solhint warnings #661

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kyzooghost
Copy link
Contributor

@kyzooghost kyzooghost commented Feb 7, 2025

This PR implements issue(s) #679

Addresses OpenZeppelin/openzeppelin-upgrades#1121

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@kyzooghost kyzooghost requested a review from a team as a code owner February 7, 2025 05:48
@kyzooghost kyzooghost changed the title fix tokenbridge init ordering given oz plugin warnings [Fix] Tokenbridge init ordering given oz plugin warnings Feb 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.46%. Comparing base (aa64956) to head (3d0077c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #661   +/-   ##
=========================================
  Coverage     68.46%   68.46%           
  Complexity     1185     1185           
=========================================
  Files           323      323           
  Lines         13130    13130           
  Branches       1318     1318           
=========================================
  Hits           8989     8989           
  Misses         3590     3590           
  Partials        551      551           
Flag Coverage Δ *Carryforward flag
hardhat 98.52% <100.00%> (ø)
kotlin 66.11% <ø> (ø) Carriedforward from b65e511

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
contracts/src/bridging/token/TokenBridge.sol 100.00% <100.00%> (ø)
contracts/src/messaging/l2/L2MessageService.sol 80.95% <100.00%> (ø)

@kyzooghost kyzooghost requested a deployment to docker-build-and-e2e February 10, 2025 07:56 — with GitHub Actions Waiting
@kyzooghost kyzooghost changed the title [Fix] Tokenbridge init ordering given oz plugin warnings [Fix] OZ-Upgrade-Plugin + Solhint warnings Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants