refactor, perf: prover/crypto/sis improvements

[gbotrel]

Sister PR in gnark-crypto.

This pull request includes significant refactoring and cleanup of the ringsis package within the prover/crypto directory. The changes mainly focus on removing unnecessary code and simplifying the implementation.

Essentially this PR uses the latest implementation from gnark-crypto, and concentrate the core logic of sis in gnark-crypto. Moreover, it reworked the TransversalHash to improve its performance (currently bls12377 only; koalabear to come).

Parameters for SIS are optimized for degree==64 and log2(bound) a multiple of 8 (byte size).

Allocations are reduced through the use of a LimbIterator . Removed buffers, locks. (the sis instance is now stateless, as it should be).

Removed all generated code for TransversalHash.

Benchmarks for transversal hash (matrix of size 1024*1024 on hpc7a )

ignoring BenchmarkTransversalHash/testcase-1100-192: before has 3 instances, after has 0
benchmark                                      old ns/op     new ns/op     delta
BenchmarkTransversalHash/testcase-0-192        3487853       3034115       -13.01%
BenchmarkTransversalHash/testcase-0-192        3549104       3317616       -6.52%
BenchmarkTransversalHash/testcase-0-192        3633424       3418450       -5.92%
BenchmarkTransversalHash/testcase-1-192        23254182      15093093      -35.10%
BenchmarkTransversalHash/testcase-1-192        23818238      15126497      -36.49%
BenchmarkTransversalHash/testcase-1-192        23526251      15075473      -35.92%
BenchmarkTransversalHash/testcase-10-192       25649222      16470154      -35.79%
BenchmarkTransversalHash/testcase-10-192       25710068      15966326      -37.90%
BenchmarkTransversalHash/testcase-10-192       25398553      16401198      -35.42%
BenchmarkTransversalHash/testcase-11-192       25284658      15625441      -38.20%
BenchmarkTransversalHash/testcase-11-192       25273225      15657162      -38.05%
BenchmarkTransversalHash/testcase-11-192       25041925      16189546      -35.35%
BenchmarkTransversalHash/testcase-100-192      24898676      15922206      -36.05%
BenchmarkTransversalHash/testcase-100-192      24709647      15831611      -35.93%
BenchmarkTransversalHash/testcase-100-192      24356574      16014427      -34.25%
BenchmarkTransversalHash/testcase-101-192      23785252      15019279      -36.85%
BenchmarkTransversalHash/testcase-101-192      23497154      14869629      -36.72%
BenchmarkTransversalHash/testcase-101-192      23961674      15057460      -37.16%
BenchmarkTransversalHash/testcase-110-192      26541592      16300219      -38.59%
BenchmarkTransversalHash/testcase-110-192      26483187      16229312      -38.72%
BenchmarkTransversalHash/testcase-110-192      26093940      16172361      -38.02%
BenchmarkTransversalHash/testcase-111-192      25964799      16054350      -38.17%
BenchmarkTransversalHash/testcase-111-192      25901920      16257190      -37.24%
BenchmarkTransversalHash/testcase-111-192      26087142      16434559      -37.00%
BenchmarkTransversalHash/testcase-1000-192     26856945      17358226      -35.37%
BenchmarkTransversalHash/testcase-1000-192     26985485      17223062      -36.18%
BenchmarkTransversalHash/testcase-1000-192     26834124      17065547      -36.40%
BenchmarkTransversalHash/testcase-1001-192     26720896      16411102      -38.58%
BenchmarkTransversalHash/testcase-1001-192     26578605      16115618      -39.37%
BenchmarkTransversalHash/testcase-1001-192     26379708      16212102      -38.54%
BenchmarkTransversalHash/testcase-1010-192     26365410      16191832      -38.59%
BenchmarkTransversalHash/testcase-1010-192     25969353      16190636      -37.65%
BenchmarkTransversalHash/testcase-1010-192     25966581      16437708      -36.70%
BenchmarkTransversalHash/testcase-1011-192     26235959      16006237      -38.99%
BenchmarkTransversalHash/testcase-1011-192     26321122      16089955      -38.87%
BenchmarkTransversalHash/testcase-1011-192     26284375      15963178      -39.27%

Benchmarks for transversal hash (matrix of size 1024102492 on hpc7a )

❯ benchcmp ringsis_64_16/ref_92x_hpc7a.txt new_92x_hpc7a8.txt
benchcmp is deprecated in favor of benchstat: https://pkg.go.dev/golang.org/x/perf/cmd/benchstat
benchmark                                     old ns/op     new ns/op     delta
BenchmarkTransversalHash/testcase-0-192       77954298      45216921      -42.00%
BenchmarkTransversalHash/testcase-1-192       645227476     570904781     -11.52%
BenchmarkTransversalHash/testcase-10-192      730085426     676721836     -7.31%
BenchmarkTransversalHash/testcase-11-192      716476925     650540575     -9.20%
BenchmarkTransversalHash/testcase-100-192     710198530     653845027     -7.93%
BenchmarkTransversalHash/testcase-101-192     715168735     657276892     -8.09%

benchmark                                     old allocs     new allocs     delta
BenchmarkTransversalHash/testcase-0-192       206417         130949         -36.56%
BenchmarkTransversalHash/testcase-1-192       206455         131116         -36.49%
BenchmarkTransversalHash/testcase-10-192      206434         131043         -36.52%
BenchmarkTransversalHash/testcase-11-192      206426         131081         -36.50%
BenchmarkTransversalHash/testcase-100-192     206371         131017         -36.51%
BenchmarkTransversalHash/testcase-101-192     206410         131042         -36.51%

benchmark                                     old bytes     new bytes     delta
BenchmarkTransversalHash/testcase-0-192       404228104     224151528     -44.55%
BenchmarkTransversalHash/testcase-1-192       404243848     224223568     -44.53%
BenchmarkTransversalHash/testcase-10-192      404235544     224193904     -44.54%
BenchmarkTransversalHash/testcase-11-192      404264456     224210528     -44.54%
BenchmarkTransversalHash/testcase-100-192     404207320     224182032     -44.54%
BenchmarkTransversalHash/testcase-101-192     404222856     224193104     -44.54%

[cla-assistant]

All committers have signed the CLA.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.40%. Comparing base (45a41b4) to head (65e859b).

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #554      +/-   ##
============================================
+ Coverage     68.12%   68.40%   +0.27%     
+ Complexity     1182     1139      -43     
============================================
  Files           326      323       -3     
  Lines         13219    12866     -353     
  Branches       1337     1308      -29     
============================================
- Hits           9006     8801     -205     
+ Misses         3658     3517     -141     
+ Partials        555      548       -7     

Flag	Coverage Δ		*Carryforward flag
hardhat	98.52% <ø> (ø)
kotlin	66.00% <ø> (+0.22%)	⬆️	Carriedforward from 26b5930

*This pull request uses carry forward flags. Click here to find out more.

see 78 files with indirect coverage changes

[AlexandreBelling]

Approved but there are a couple of issues on the CI

[github-actions]

PR has had no activity for 30 days. What is blocking it? Is there anything you can do to help move it forward? Without action it will be closed in 7 days.