Optimize ReadN in CDC by collecting records in batches #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hariso
changed the title
hariso
commented
May 14, 2025
Comment on lines
-583
to
-588
| records, err := i.NextN(ctx, 5) | ||
| if err != nil { | ||
| is.True(strings.Contains(err.Error(), "logical replication error")) | ||
| } else { | ||
| is.True(len(records) > 0) | ||
| } |
There was a problem hiding this comment.
When I read this part of the test, I wasn't sure what the expected behavior was (i.e., whether we expected an error or not). Based on the test description ("subscription termination"), it appeared to me that an error is what we should always expect.
hariso
commented
May 14, 2025
hariso
force-pushed
the
haris/read-n-batches
branch
from
d288eee to
c181d90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #278.
Quick checks: