Fix: Flags reported as falsy despite being set by the user when invok…

…ing a connector (#234)

* Move binding to Cobra command

* Remove visiting persistent flags from each command

`command.Flags()` already lists all persistent and regular flags

* Bind Cobra with Viper early as possible

pkg/cli/commands.go

@@ -33,7 +33,16 @@ func MakeMainCommand(
 	getconnector GetConnectorFunc,
 	opts ...connectorrunner.Option,
 ) func(*cobra.Command, []string) error {
-	return func(*cobra.Command, []string) error {
+	return func(cmd *cobra.Command, args []string) error {
+		// NOTE(shackra): bind all the flags (persistent and
+		// regular) with our instance of Viper, doing this
+		// anywhere else may fail to communicate to Viper the
+		// values gathered by Cobra.
+		err := v.BindPFlags(cmd.Flags())
+		if err != nil {
+			return err
+		}
+
 		runCtx, err := initLogger(
 			ctx,
 			name,
@@ -176,7 +185,16 @@ func MakeGRPCServerCommand(
 	confschema field.Configuration,
 	getconnector GetConnectorFunc,
 ) func(*cobra.Command, []string) error {
-	return func(*cobra.Command, []string) error {
+	return func(cmd *cobra.Command, args []string) error {
+		// NOTE(shackra): bind all the flags (persistent and
+		// regular) with our instance of Viper, doing this
+		// anywhere else may fail to communicate to Viper the
+		// values gathered by Cobra.
+		err := v.BindPFlags(cmd.Flags())
+		if err != nil {
+			return err
+		}
+
 		runCtx, err := initLogger(
 			ctx,
 			name,
@@ -281,7 +299,16 @@ func MakeCapabilitiesCommand(
 	confschema field.Configuration,
 	getconnector GetConnectorFunc,
 ) func(*cobra.Command, []string) error {
-	return func(*cobra.Command, []string) error {
+	return func(cmd *cobra.Command, args []string) error {
+		// NOTE(shackra): bind all the flags (persistent and
+		// regular) with our instance of Viper, doing this
+		// anywhere else may fail to communicate to Viper the
+		// values gathered by Cobra.
+		err := v.BindPFlags(cmd.Flags())
+		if err != nil {
+			return err
+		}
+
 		runCtx, err := initLogger(
 			ctx,
 			name,

pkg/config/config.go

@@ -88,48 +88,30 @@ func DefineConfiguration(
 
 	mainCMD.AddCommand(cli.AdditionalCommands(connectorName, schema.Fields)...)
 
-	if err := v.BindPFlags(mainCMD.PersistentFlags()); err != nil {
-		return nil, nil, err
-	}
-	if err := v.BindPFlags(mainCMD.Flags()); err != nil {
-		return nil, nil, err
-	}
+	// NOTE(shackra): Set all values from Viper to the flags so
+	// that Cobra won't complain that a flag is missing in case we
+	// pass values through environment variables
 
 	// main subcommand
 	mainCMD.Flags().VisitAll(func(f *pflag.Flag) {
 		if v.IsSet(f.Name) {
 			_ = mainCMD.Flags().Set(f.Name, v.GetString(f.Name))
 		}
 	})
-	mainCMD.PersistentFlags().VisitAll(func(f *pflag.Flag) {
-		if v.IsSet(f.Name) {
-			_ = mainCMD.PersistentFlags().Set(f.Name, v.GetString(f.Name))
-		}
-	})
 
 	// children process subcommand
 	grpcServerCmd.Flags().VisitAll(func(f *pflag.Flag) {
 		if v.IsSet(f.Name) {
 			_ = grpcServerCmd.Flags().Set(f.Name, v.GetString(f.Name))
 		}
 	})
-	grpcServerCmd.PersistentFlags().VisitAll(func(f *pflag.Flag) {
-		if v.IsSet(f.Name) {
-			_ = grpcServerCmd.PersistentFlags().Set(f.Name, v.GetString(f.Name))
-		}
-	})
 
 	// capabilities subcommand
 	capabilitiesCmd.Flags().VisitAll(func(f *pflag.Flag) {
 		if v.IsSet(f.Name) {
 			_ = capabilitiesCmd.Flags().Set(f.Name, v.GetString(f.Name))
 		}
 	})
-	capabilitiesCmd.PersistentFlags().VisitAll(func(f *pflag.Flag) {
-		if v.IsSet(f.Name) {
-			_ = capabilitiesCmd.PersistentFlags().Set(f.Name, v.GetString(f.Name))
-		}
-	})
 
 	return v, mainCMD, nil
 }