Lucidchart connector #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusGoldschmidt
force-pushed
the
goldschmidt/lucidchart-start
branch
from
a574b47 to
816cb63
Compare
MarcusGoldschmidt
force-pushed
the
goldschmidt/lucidchart-start
branch
from
816cb63 to
226b93f
Compare
ggreer
reviewed
Jan 30, 2025
ggreer
reviewed
Jan 30, 2025
ggreer
reviewed
Jan 30, 2025
| } | ||
|
|
||
| func (o *folderBuilder) Revoke(ctx context.Context, grant *v2.Grant) (annotations.Annotations, error) { | ||
| if grant.Principal.Id.ResourceType == userResourceType.Id { |
There was a problem hiding this comment.
Nitpick: I think it's easier to read this code if we early return.
Suggested change
| if grant.Principal.Id.ResourceType == userResourceType.Id { | |
| if grant.Principal.Id.ResourceType != userResourceType.Id { | |
| return nil, fmt.Errorf("resource type %s is not supported", grant.Principal.Id.ResourceType) | |
| } |
shackra
requested changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.